Stop coalescing NULL to empty string in key provider functions #367
Conversation
|
Does anyone involved when these were added remember why it was done? I'm all for removing them unless we have really good reasons to have them, as they might hide bugs |
If there are bugs in there that the |
Since we can pass NULL values in the functions which takes JSON it makes no sense to not do so in the functions which take text. By doing this we only risk not excercising some code paths.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (85.35%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #367 +/- ##
=====================================================
+ Coverage 85.20% 85.35% +0.15%
=====================================================
Files 22 22
Lines 2534 2533 -1
Branches 384 383 -1
=====================================================
+ Hits 2159 2162 +3
+ Misses 301 297 -4
Partials 74 74
🚀 New features to boost your workflow:
|
Since we can pass NULL values in the functions which takes JSON it makes no sense to not do so in the functions which take text. By doing this we only risk not excercising some code paths.